seren / freenas-temperature-graphing

Scripts to graph FreeNAS CPU and drive temperatures
Other
77 stars 14 forks source link

temps-rrd-format.sh line 85 has no closing quote. #6

Closed ingestre closed 7 years ago

ingestre commented 7 years ago

Line currently reads [ -n $verbose ] && echo "Cleaned up data:

In addition please pay attention to the use of quotes with the -n test operator. From the manual...

The -n test requires that the string be quoted within the test brackets. Using an unquoted string with ! -z, or even just the unquoted string alone within test brackets normally works, however, this is an unsafe practice. Always quote a tested string

seren commented 7 years ago

Thanks for catching that.