search

serenadeai / serenade

Apache License 2.0
317 stars 57 forks source link

Focus command no longer works in macOS sonoma #31

Open katarinaslama opened 7 months ago

katarinaslama commented 7 months ago

System Information

Serenade Version: v2.0.2

OS and Version: macOS 14.3 (and previous Sonoma versions)

Application: focus command: I use ITerm, VSCode, and Chrome

Issue Description

After updating to macOS Sonoma, the focus command no longer works. It will sometimes bring the correct application to the front, but it does not actually focus it. Many times it doesn't work at all. It works the worst with focus VSCode. The launch command can replace focus for Chrome and iTerm, but this does not work for VSCode.

Matt says: Here’s the underlying library that gets triggered, and likely where the fix needs to be: https://github.com/serenadeai/driver

There’s a test for focus here that would confirm it’s in this library: https://github.com/serenadeai/driver/blob/master/test/focus.js

How to Reproduce

Download serenade on macOS Sonoma and try focusing between applications.

DeFiFoFum commented 7 months ago

I'm dealing with the same issue.

gregnavis commented 6 months ago

I'm dealing with the same issue. However, after pulling the driver repo and building it by running yarn, I am able to focus windows via node test/focus.js code.

qredwoods commented 6 months ago

C++ contribution opportunity. See PR#19 in 2021 to fix mac Focus issues. (by @tmacwill, any leads on this new focus issue?) Per reviewed changes, mac.cpp and mac.hpp were modified, may be where fix lies this time.