search

serenadeai / serenade

Apache License 2.0
317 stars 57 forks source link

Option to disable the edit command in VS Code (to never open the revision box in VS code) #6

Open katarinaslama opened 2 years ago

katarinaslama commented 2 years ago

Context

I never have a reason to use the revision box in VS Code. However, serenade often mis-hears "indent" as "edit" and opens the annoying revision box. Tommy tells me that there is no way to suppress this behavior (since changing settings.json does not solve this version of suppressing the revision box.) and suggested that that I open an issue here.

I made a quick fix by adding this to custom.js: serenade.app("code").command("edit", async (api) => { await api.pressKey(); });

But this does not fix the case where serenade mis hears "line 88" as "line, edit".

Goals

Make an option to disable the 'edit' command in vs code.

Proposed Solution

Make an option to disable the 'edit' command in vs code.

Alternatives

Maybe there's a way to solve the "line 88" issue? This didn't work though:

serenade.app("code").command("line, edit", async (api) => { await api.pressKey("g", ["ctrl"]); await api.typeText("88"); });

Thanks!

MattWiethoff commented 2 years ago

At some point I believe we were planning on renaming "edit" to "revise" for this reason, but looks like we currently support both. Seems like we can go ahead and remove "edit" from the grammar.