sereneinserenade / tiptap-languagetool

Tiptap-Extension to integrate LanguageTool to Tiptap 2.
https://tiptap-languagetool.vercel.app/
MIT License
115 stars 16 forks source link

Live demo deployment is failing #5

Open escapedcat opened 7 months ago

escapedcat commented 7 months ago
image

just fyi

sereneinserenade commented 7 months ago

Hi, thanks for reporting

For now, it can be run locally from mocked-demo branch. I'll try & deploy it on github pages in some time.

escapedcat commented 7 months ago

Tried to use the mocked-demo but failed with a classic node-gyp error. Added python2 via asdf but still couldn't get it to work.

I just wanted to check a functionality. In your video it looks like you can click (just one, not double) i.e. "time where" and both qords are marked and the bubble is showing:

image

After setting everything up I can't get this to work. The bubble only shows when selecting a word manaully or doing so by double-clicking. Might have missed something but debugging only got me so far without any result.

Anyways, thanks for your work and the project! PoC works!

Error

npm ERR! code 1
npm ERR! path /tiptap-languagetool/node_modules/node-sass
npm ERR! command failed
npm ERR! command sh -c node scripts/build.js
npm ERR! Building: /Users/user/.asdf/installs/nodejs/18.19.0/bin/node /tiptap-languagetool/node_modules/node-gyp/bin/node-gyp.js rebuild --verbose --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp verb cli [
npm ERR! gyp verb cli   '/Users/user/.asdf/installs/nodejs/18.19.0/bin/node',
npm ERR! gyp verb cli   '/tiptap-languagetool/node_modules/node-gyp/bin/node-gyp.js',
npm ERR! gyp verb cli   'rebuild',
npm ERR! gyp verb cli   '--verbose',
npm ERR! gyp verb cli   '--libsass_ext=',
npm ERR! gyp verb cli   '--libsass_cflags=',
npm ERR! gyp verb cli   '--libsass_ldflags=',
npm ERR! gyp verb cli   '--libsass_library='
npm ERR! gyp verb cli ]
npm ERR! gyp info using node-gyp@3.8.0
npm ERR! gyp info using node@18.19.0 | darwin | arm64
npm ERR! gyp verb command rebuild []
npm ERR! gyp verb command clean []
npm ERR! gyp verb clean removing "build" directory
npm ERR! gyp verb command configure []
npm ERR! gyp verb check python checking for Python executable "python2" in the PATH
npm ERR! gyp verb `which` succeeded python2 /Users/user/.asdf/shims/python2
npm ERR! gyp verb check python version `/Users/user/.asdf/shims/python2 -c "import sys; print "2.7.18
npm ERR! gyp verb check python version .%s.%s" % sys.version_info[:3];"` returned: %j
npm ERR! gyp verb get node dir no --target version specified, falling back to host node version: 18.19.0
npm ERR! gyp verb command install [ '18.19.0' ]
npm ERR! gyp verb install input version string "18.19.0"
npm ERR! gyp verb install installing version: 18.19.0
npm ERR! gyp verb install --ensure was passed, so won't reinstall if already installed
npm ERR! gyp verb install version is already installed, need to check "installVersion"
npm ERR! gyp verb got "installVersion" 9
npm ERR! gyp verb needs "installVersion" 9
npm ERR! gyp verb install version is good
npm ERR! gyp verb get node dir target node version installed: 18.19.0
npm ERR! gyp verb build dir attempting to create "build" dir: /tiptap-languagetool/node_modules/node-sass/build
npm ERR! gyp verb build dir "build" dir needed to be created? /tiptap-languagetool/node_modules/node-sass/build
npm ERR! gyp verb build/config.gypi creating config file
npm ERR! gyp verb build/config.gypi writing out config file: /tiptap-languagetool/node_modules/node-sass/build/config.gypi
npm ERR! (node:52436) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future the property will be read-only.
npm ERR! (Use `node --trace-deprecation ...` to show where the warning was created)
npm ERR! gyp verb config.gypi checking for gypi file: /tiptap-languagetool/node_modules/node-sass/config.gypi
npm ERR! gyp verb common.gypi checking for gypi file: /tiptap-languagetool/node_modules/node-sass/common.gypi
npm ERR! gyp verb gyp gyp format was not specified; forcing "make"
npm ERR! gyp info spawn /Users/user/.asdf/shims/python2
npm ERR! gyp info spawn args [
npm ERR! gyp info spawn args   '/tiptap-languagetool/node_modules/node-gyp/gyp/gyp_main.py',
npm ERR! gyp info spawn args   'binding.gyp',
npm ERR! gyp info spawn args   '-f',
npm ERR! gyp info spawn args   'make',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/tiptap-languagetool/node_modules/node-sass/build/config.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/tiptap-languagetool/node_modules/node-gyp/addon.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/Users/user/.node-gyp/18.19.0/include/node/common.gypi',
npm ERR! gyp info spawn args   '-Dlibrary=shared_library',
npm ERR! gyp info spawn args   '-Dvisibility=default',
npm ERR! gyp info spawn args   '-Dnode_root_dir=/Users/user/.node-gyp/18.19.0',
npm ERR! gyp info spawn args   '-Dnode_gyp_dir=/tiptap-languagetool/node_modules/node-gyp',
npm ERR! gyp info spawn args   '-Dnode_lib_file=/Users/user/.node-gyp/18.19.0/<(target_arch)/node.lib',
npm ERR! gyp info spawn args   '-Dmodule_root_dir=/tiptap-languagetool/node_modules/node-sass',
npm ERR! gyp info spawn args   '-Dnode_engine=v8',
npm ERR! gyp info spawn args   '--depth=.',
npm ERR! gyp info spawn args   '--no-parallel',
npm ERR! gyp info spawn args   '--generator-output',
npm ERR! gyp info spawn args   'build',
npm ERR! gyp info spawn args   '-Goutput_dir=.'
npm ERR! gyp info spawn args ]
npm ERR! Traceback (most recent call last):
npm ERR!   File "/tiptap-languagetool/node_modules/node-gyp/gyp/gyp_main.py", line 16, in <module>
npm ERR!     sys.exit(gyp.script_main())
npm ERR!   File "/tiptap-languagetool/node_modules/node-gyp/gyp/pylib/gyp/__init__.py", line 545, in script_main
npm ERR!     return main(sys.argv[1:])
npm ERR!   File "/tiptap-languagetool/node_modules/node-gyp/gyp/pylib/gyp/__init__.py", line 538, in main
npm ERR!     return gyp_main(args)
npm ERR!   File "/tiptap-languagetool/node_modules/node-gyp/gyp/pylib/gyp/__init__.py", line 514, in gyp_main
npm ERR!     options.duplicate_basename_check)
npm ERR!   File "/tiptap-languagetool/node_modules/node-gyp/gyp/pylib/gyp/__init__.py", line 130, in Load
npm ERR!     params['parallel'], params['root_targets'])
npm ERR!   File "/tiptap-languagetool/node_modules/node-gyp/gyp/pylib/gyp/input.py", line 2783, in Load
npm ERR!     variables, includes, depth, check, True)
npm ERR!   File "/tiptap-languagetool/node_modules/node-gyp/gyp/pylib/gyp/input.py", line 399, in LoadTargetBuildFile
npm ERR!     includes, True, check)
npm ERR!   File "/tiptap-languagetool/node_modules/node-gyp/gyp/pylib/gyp/input.py", line 271, in LoadOneBuildFile
npm ERR!     aux_data, includes, check)
npm ERR!   File "/tiptap-languagetool/node_modules/node-gyp/gyp/pylib/gyp/input.py", line 308, in LoadBuildFileIncludesIntoDict
npm ERR!     LoadOneBuildFile(include, data, aux_data, None, False, check),
npm ERR!   File "/tiptap-languagetool/node_modules/node-gyp/gyp/pylib/gyp/input.py", line 251, in LoadOneBuildFile
npm ERR!     None)
npm ERR!   File "/Users/user/.node-gyp/18.19.0/include/node/common.gypi", line 1
npm ERR!     e_data_file_flag%': 1
npm ERR!                         ^
npm ERR! SyntaxError: EOL while scanning string literal
npm ERR! gyp ERR! configure error
npm ERR! gyp ERR! stack Error: `gyp` failed with exit code: 1
npm ERR! gyp ERR! stack     at ChildProcess.onCpExit (/tiptap-languagetool/node_modules/node-gyp/lib/configure.js:345:16)
npm ERR! gyp ERR! stack     at ChildProcess.emit (node:events:517:28)
npm ERR! gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:292:12)
npm ERR! gyp ERR! System Darwin 23.2.0
npm ERR! gyp ERR! command "/Users/user/.asdf/installs/nodejs/18.19.0/bin/node" "/tiptap-languagetool/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
npm ERR! gyp ERR! cwd /tiptap-languagetool/node_modules/node-sass
npm ERR! gyp ERR! node -v v18.19.0
npm ERR! gyp ERR! node-gyp -v v3.8.0
npm ERR! gyp ERR! not ok
npm ERR! Build failed with error code: 1
sereneinserenade commented 7 months ago

I'll try converting it to https://vitejs.dev/. That should fix this issue. I'll get to it this weekend.

sereneinserenade commented 7 months ago

I just wanted to check a functionality. In your video it looks like you can click (just one, not double) i.e. "time where" and both qords are marked and the bubble is showing.

Both the range of error and it's replacement is given by languagetool-server. This extension & demo just renderes it depending on that.