serengil / deepface

A Lightweight Face Recognition and Facial Attribute Analysis (Age, Gender, Emotion and Race) Library for Python
https://bit.ly/deepface-py
MIT License
14.68k stars 2.22k forks source link

FaceNet model has InceptionResNetV1 backbone instead of InceptionResNetV2 #1144

Closed serengil closed 7 months ago

serengil commented 7 months ago

In the backbone of model, model name is incorrectly mentioned as v2 instead of v1: https://github.com/serengil/deepface/blob/master/deepface/basemodels/Facenet.py#L100

As i confirmed from its training documentation, we are using v1: https://sefiks.com/2018/09/03/face-recognition-with-facenet-in-keras/

Besides, reference repo mentioned it is using v1 for the pre-trained models: https://github.com/davidsandberg/facenet

These should be updated. Also, give a credit of the reference model in the source code.

serengil commented 7 months ago

Closed with PR - https://github.com/serengil/deepface/pull/1151