serengil / deepface

A Lightweight Face Recognition and Facial Attribute Analysis (Age, Gender, Emotion and Race) Library for Python
https://www.youtube.com/watch?v=WnUVYQP4h44&list=PLsS_1RYmYQQFdWqxQggXHynP1rqaYXv_E&index=1
MIT License
11.97k stars 2.03k forks source link

[FEATURE]: Manual image_file to pkl_representation management #1233

Closed BrunoMarinhoM closed 4 months ago

BrunoMarinhoM commented 4 months ago

Description

Additional Info

No response

serengil commented 4 months ago

thank you for the recommendation

i think we should not have an argument updated_images at all. deepface tries to offer simple user experience. this makes it complexer.

having refresh_database argument with true default value would be good. if someone sets this to false, then it will use the existing pkl file.

do you mind to create a PR if you already have the enhancement in your branch?

BrunoMarinhoM commented 4 months ago

Surely! No problem. :)

BrunoMarinhoM commented 4 months ago

See https://github.com/serengil/deepface/pull/1235. :+1: :)

serengil commented 4 months ago

thanks, added some minor comments. then, will be happy to merge.

BrunoMarinhoM commented 4 months ago

Feature added on PR https://github.com/serengil/deepface/pull/1235.