search

serengil / deepface

A Lightweight Face Recognition and Facial Attribute Analysis (Age, Gender, Emotion and Race) Library for Python
https://www.youtube.com/watch?v=WnUVYQP4h44&list=PLsS_1RYmYQQFdWqxQggXHynP1rqaYXv_E&index=1
MIT License
10.85k stars 1.91k forks source link

ISSUE #1233: Feature refresh_database argument added to method find #1235

Closed BrunoMarinhoM closed 1 month ago

BrunoMarinhoM commented 1 month ago

Tickets

https://github.com/serengil/deepface/issues/1233

What has been done

With this PR, the method refresh_database (boolean) allows the user to choose between sync the pkl file with the database directory and keep it up to date with the files inside that directory or ignore any file changes and do the recognition only with the representations in the pkl file. Also a logger.info saying that the user is possibly out of sync for better user experience;

How to test

make lint && make test
BrunoMarinhoM commented 1 month ago

All resolved in the commit b4a35fe80b6e28e3d8b1880ef3822298af90b836;

Thanks for the feedback.

serengil commented 1 month ago

LGTM

PS: Pipeline failed because of linting but it mostly related to other files than this PR. I will handle it.

BrunoMarinhoM commented 1 month ago

Great. Thanks for the work on this framework! It's been really useful to me.

Issue #1233 closed. :+1: