serengil / deepface

A Lightweight Face Recognition and Facial Attribute Analysis (Age, Gender, Emotion and Race) Library for Python
https://www.youtube.com/watch?v=WnUVYQP4h44&list=PLsS_1RYmYQQFdWqxQggXHynP1rqaYXv_E&index=1
MIT License
14.34k stars 2.2k forks source link

Open more feature PR's at once? #329

Closed RoelofRuis closed 3 years ago

RoelofRuis commented 3 years ago

Dear Sefik,

In the past week I have built some more features which I would like to propose for merging:

All features should not change the current behavior of the library (except in very minor ways where indicated)

These features are all built upon the currently open PR (https://github.com/serengil/deepface/pull/325) and all build upon each other in a certain order.

My question is: Shall I open all PR's already and indicate the order in which they should be reviewed or should I open them one by one as the previous one gets merged?

Cheers!

serengil commented 3 years ago

one by one is better buddy.

I plan to merge your PR in the next couple of days.

thank you for your all support in advance.