search

serenity-bdd / serenity-cucumber-starter

A skeleton project for Serenity BDD and Cucumber JVM
Apache License 2.0
180 stars 285 forks source link

master branch contains the screenplay pattern and not classic one #33

Open mayank-kapoor opened 4 years ago

mayank-kapoor commented 4 years ago

@wakaleo: master branch has the screenplay pattern rather the classic one.

Can you update the code.

Can see you updated screenplay pattern on master branch in this commit : 7e1bb0f86eb9817aebb3d28ce30370a7a81cd8c8

Any specific reason as screenplay is already on different branch ?

wakaleo commented 4 years ago

That's intentional, but you don't have to use that approach if you don't want to - the action classes pattern is in the action-classes branch.

traumatic commented 3 years ago

Thanks. I think what is confusing is that the wiki page states the following "There are two versions to choose from. The master branch uses a more classic approach, using action classes and lightweight page objects, whereas the screenplay branch shows the same sample test implemented using Screenplay."

wakaleo commented 3 years ago

True, that needs updating. The Screenplay approach is now the preferred approach, but you can still use action classes or even plain page objects if it makes more sense for your context.

traumatic commented 3 years ago

Thanks John. The pom file in the action-classes branch shows screenplay dependencies. What are all the dependencies required if no screenplay dependencies are to be used? Is there an example you can refer to?

traumatic commented 3 years ago

Ok,seems that dropping them is sufficient.