Serenity core issue 1066

serenity-bdd / serenity-cucumber

Cucumber integration for the Serenity BDD Reporting library

Other

78 stars 74 forks source link

Serenity core issue 1066 #122

Closed DuanYuePeng closed 6 years ago

DuanYuePeng commented 6 years ago

This will fix the issue #1066 in the serenity-core project.

wakaleo commented 6 years ago

That looks great, thajs. could you include some unit tests as well to illustrate this change amd to prevent regressions?

DuanYuePeng commented 6 years ago

Sure, I'll add a unit test and make sure most of the tests pass. However, some tests access "https://duckduckgo.com", which I can not access from my country. So I can not assure those tests.