fixes for parallel run by scenario in one jvm

serenity-bdd / serenity-cucumber

Cucumber integration for the Serenity BDD Reporting library

Other

78 stars 74 forks source link

Closed odemkovych closed 5 years ago

odemkovych commented 5 years ago

when run features in parallel mode by scenario we got 'no basesteplistener' exception caused by SerenityReporter was not thread safe. In scenario mode feature goes as (feature path):(line number) and SerenityReporter used just (feature path) to identify event bus. That obviously caused wrong situation when threads tried to share event bus object.

wakaleo commented 5 years ago

Looks good, thanks for your contribution

wakaleo commented 5 years ago

Do you have a sample project that demonstrates the fix in action?

odemkovych commented 5 years ago

I've used it in a project I currently working on. Unfortunately I can't share it in whole but I can share some maven configs if you like.

wakaleo commented 5 years ago

Could you create a branch of one of the demo projects?

odemkovych commented 5 years ago