serenity-bdd / serenity-cucumber

Cucumber integration for the Serenity BDD Reporting library
Other
78 stars 74 forks source link

Scenario Outline with PendingException marked as Passing instead of Pending #21

Closed dwursteisen closed 8 years ago

dwursteisen commented 8 years ago

Hello,

If a scenario outline has steps which throwing PendingException, the scenario is marked as Passing. I expected this scenario should be marked as Pending. Is it expected ?

If the scenario is not a scenario outline, the scenario is marked as Ignored It's not Pending, as I would expeded but, unlike the previous result, it's not a false positive.

To reproduce the problem :

I think that the problem is in the SerenityReporter which doesn't support Pending result. In the previous repository, I try to fix the problem building my own SerenityReporter : Please see CucumberWithSerenityFix class

cliviu commented 8 years ago

Hi @dwursteisen . Thanks for the efforts of creating the bug report. Your change looks good, I will analyse it and I will get back to you.

cliviu commented 8 years ago

Hi @dwursteisen. I reviewed your bug fix and integrated in serenity cucumber, now the report looks like this for the scenario outline : all_examples

all_examples_steps

After one step throws the PendingException, all following steps are marked as Skipped/Ignored.

YamStranger commented 8 years ago

It seems that this bug already fixed and can not be reproduced