search

serenity-bdd / serenity-documentation

The main Serenity BDD documentation
Apache License 2.0
41 stars 61 forks source link

Unclear documentation for serenity.timeout property #121

Closed kot-ch closed 6 years ago

kot-ch commented 6 years ago

The documentation for serenity.timeout property is unclear. As stated in "Running Serenity tests from the command line" chapter:

serenity.timeout How long should the driver wait for elements not immediately visible.

As it can be guessed, the timeout should be specified in milliseconds (seconds are just too long spaces of time from webdriver's perspective). But it will be better to clearly say about unit of time like it's already done for webdriver.timeouts.implicitlywait and webdriver.wait.for.timeout properties.

wakaleo commented 6 years ago

PRs are welcome

kot-ch commented 6 years ago

Hi @wakaleo,

I've created PR: https://github.com/serenity-bdd/serenity-documentation/pull/122

kot-ch commented 6 years ago

PR has been merged. So I close the issue. Thank you very much.