Closed chris-dare closed 2 years ago
Hey @TuyizereBapt, you'll need to implement a method on Stock like Stock.pop()
It will help us encapsulate the behaviour of topping up the inventory through ops like cancelations/refunds
So I'm thinking something
def push(self, quantity_to_add: int, actor: User) -> (Stock, InventoryActionHistory)
Then you can call this in ChargeItemCancelation to update inventory on bill cancelation
- When paying for a charge item, if a client account is used to make the payment, then we will set the charge_item's mode of payment to client_account.payment_mode
- Otherwise, we will set the mode of payment to patient_account.payment_mode
Which method on ChargeItem as shown in the snapshot below is used to pay for a ChargeItem? both? ChargeItem.settle_payment() is somehow confusing
Use settle_payment
Please run a safe delete on settle_payment_with_corporate
and take it out if it's not used anywhere. We don't use it anymore
Use
settle_payment
Please run a safe delete on
settle_payment_with_corporate
and take it out if it's not used anywhere. We don't use it anymore
So how do I know which type of account is used to pay for the ChargeItem? From the info in screshots below
Is it PaymentInfoPydanticModel.account_id or PaymentInfoPydanticModel.account? Os something else?
Why multiple charge_items by charge_items = process_payment_via_account(...)
?
Under settle_payment, The charge item in
charge_item = charge_items[0]
Will have either a patient_account, a payer_account or both.
It there is a charge_item.patient_account
, set the mode to patient_account.payment_mode
Otherwise, set it to charge_item.payer_account.payment_mode
Under settle_payment, The charge item in
charge_item = charge_items[0]
Will have either a patient_account, a payer_account or both.
It there is a
charge_item.patient_account
, set the mode topatient_account.payment_mode
Otherwise, set it tocharge_item.payer_account.payment_mode
Okay. Thanks
You're welcome. I just updated the comment FYI
Use
settle_payment
Please run a safe delete on
settle_payment_with_corporate
and take it out if it's not used anywhere. We don't use it anymore
It looks like settle_payment_with_corporate
is used somewhere
ok. just raise a NotImplementedError in settle_payment_with_corporate
with todo to delete
Alternatively, you can delete that ..WithdrawalListView. It's useless
Let me delete both the View where it's used and the method itself
Sure
That ChargeItem.stock_item
Isn't the reference of the foreignkey wrong? I think it should have been Stock rather ChargeItem
How can I know the stock associated with the ChargeItem?
That's correct. Change it
See medication.models.MedicationDispense.create
,
Particularly in 355 that says # create charge item for that dispense and add to the invoice
See
medication.models.MedicationDispense.create
,Particularly in 355 that says
# create charge item for that dispense and add to the invoice
What does this mean?
This is where you can can set the stock on the charge item being created
That's correct. Change it
Is this not going to break things?
Depends. What would you like to do?
This is where you can can set the stock on the charge item being created
inventory_item
is Stock right?
That's correct. Let's have a chat on this. Please come to Gather
Concerning revoking a service request, there are 3 things that are necessary:
ServiceRequest
called:
a. canceled_by_practitioner
-> FK to the Practitionerrole
where the practitionerrole must have the same managing organization as ServiceRequest.healthcareservice.provider
.canceled_by_user
-> FK to authenticationmanager.User
c. canceled_by_name
-> Text of the fullname of the canceled_by_practitioner if not null else canceled_by_userWe need canceled_by_user
because when the patient portal comes online, users may have the ability to cancel diagnostic service request which they are yet to pay for.
Hi @pkdadson, I noticed that samples can be taken for a test when it's revoked. Please update this so the samples are only taken if the status is active
. Because that's the only stage where a sample is expected to be collected to continue the process.
@dexios1 this is fixed
Thank you very much
Tell us about your request! Update the bill cancelation feature on Serenity such that authorized practitioners (AP's) can request cancelations which can be approved and finally marked as cancelled upon reversal of payments.
See the Serenity EMR - Bill cancelations flowchart to learn more about the bill cancelation procedure. A screenshot of that flow is listed below. The original copy is available here
Here's what we should be able to accomplish following this improvement:
In scope
Out of scope
Which app does this concern? Provider portal? Corporate portal? Patient app?
What will be benefit of this feature? What's the value of this feature? If you can quantity it, that would be awesome!
Describe the solution you'd like We're going to implement the flow in the description above with the exception its notification feature
Here's what should be updated in the app:
CREDIT
, orDEBIT
DEBIT
and the for ClientAccount, this will beCREDIT
ChargeItemCancelation.cancel
, if the chargeitem has stock items (i.e. stock items were dispensed for the bill) then we will update the stock and record its adjustmentChargeItemCancelation.approve
, if the chargeitem was paid in credit mode, then we will automatically callChargeItemCancelation.cancel
within the model as well Note: Be sure to check and confirm thatChargeItemCancelation.cancel
does not raise bugs. Some of that activity has been spotted in the appDescribe alternatives you've considered N/A
Additional context N/A