search

serenity-health / roadmap

Public roadmap for development of Serenity's apps reported by our community of users
0 stars 1 forks source link

bugfix/edit insurance beneficiary #126

Open TuyizereBapt opened 2 years ago

TuyizereBapt commented 2 years ago

Describe the bug There is a mismatch between the backend implementation and front-end usage of the API endpoint for editing an insurance beneficiary (https://serenity-health.readme.io/reference/insurance-clients-and-payments#edit-an-insurance-beneficiary)

Impact What is the impact of this problem?

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://demo.provider.serenity.health/clients/25c92ebe-30fd-4cc4-bfcf-5958b77bd7e6/benefactors'
  2. Search for a specific beneficiary, and under action menu, click on edit
  3. Make modifications and click update beneficiary button (Side note: insurance provider field and health policy fields could not load data for selection when I was testing. And not all data is pre-filled into the fields)
  4. See error

Note that, although an employee can also be an insurance beneficiary with a SELF (independent) relationship, there are other patients who can be insurance beneficiaries with DEPENDENT relationship

Expected behavior The insurance beneficiary should successfully be updated

Screenshots/Screencast image

Request payload. From the request payload below, it is clear that what's being sent is an employee's data image

What the API expects image

Additional context N/A

TuyizereBapt commented 2 years ago

@dexios1 let's look at this tomorrow to get it out of way

TuyizereBapt commented 2 years ago

Fixed by: https://github.com/serenity-health/core-systems-api/pull/87

chris-dare commented 2 years ago

Hi @TuyizereBapt please take Dadson through the integration of this

TuyizereBapt commented 2 years ago

Hi @TuyizereBapt please take Dadson through the integration of this

Yes. @pkdadson should let me know any challenges he might face while integrating this. I remember he was the one who raised this issue.