serenity-is / Serenity

Business Apps Made Simple with Asp.Net Core MVC / TypeScript
https://serenity.is
MIT License
2.57k stars 796 forks source link

[Bug report]: grids are not using full height after upgrading to 6.8 #6938

Closed RaptorTrap closed 11 months ago

RaptorTrap commented 11 months ago

Before submitting the bug report, please read and check the following items

What happened?

After upgrading a vanilla serene template to 6.8, all grids are not using the full height and appear squashed: image

What did you expect to happen?

Grids using the full height like before.

How to reproduce?

Create a serene template (6.7.1) upgrade to 6.8 and open any grid

What Serenity Nuget Versions are you seeing the problem on? (separated by comma)

6.8

Relevant log output

No response

Serene template version

No response

Sergen version

No response

Code editor

No response

Operating System

No response

Node.js version

No response

TypeScript version

No response

Database type and version

No response

On which device do you see the problem?

No response

On which operating system do you see the problem?

No response

On which browsers do you see the problem?

No response

On what version of the browsers do you see the problem?

No response

Additional information

No response

VictorTomaili commented 11 months ago

Use CSS to make it full height. Check the changelog.

RaptorTrap commented 11 months ago

I know that I can change it through css, but shouldn't it work out of the box, if it was working fine the version before?

VictorTomaili commented 11 months ago

I marked this as a bug already. This is a fix before the release next template

volkanceylan commented 11 months ago

See this commit https://github.com/serenity-is/serene/commit/348802081e1ae72ca5f2b988d0c276a08bfbfe00

This is not a Serenity issue, and it is clearly stated in changelog that changes should be applied manually after updating

RaptorTrap commented 11 months ago

Yeah, I found it mentioned in the Release Notes, but its not really mentioned in the Changelog. Would be good if it was also mentioned in the Changelog or linked to the Release Notes.