serenity-is / Serenity

Business Apps Made Simple with Asp.Net Core MVC / TypeScript
https://serenity.is
MIT License
2.57k stars 796 forks source link

[Bug report]: Dialog does not move to associated tab when a validation error occurs #7002

Closed liamrhomer closed 8 months ago

liamrhomer commented 8 months ago

Before submitting the bug report, please read and check the following items

What happened?

When there is an empty or incorrect field in a tabbed dialog, it does not switch to the tab with the field and stays in place on the current tab.

This issue occurs both on the online StartSharp Demo and also on my local machine using the latest packages.

What did you expect to happen?

In older versions of Serenity, this would automatically move you to the tab where the field was incorrect.

How to reproduce?

When looking at the Startsharp demo at: https://demo.serenity.is/ and going to the following page: https://demo.serenity.is/BasicSamples/OtherFormInTab.

If you delete the order date in one of the entries, move to the second tab "Shipping" and hit save, it indicates that "This field is required." and gives a validation error message but it does not switch tabs back to "General".

What Serenity Nuget Versions are you seeing the problem on? (separated by comma)

6.9.5

Relevant log output

No response

Serene template version

No response

Sergen version

No response

Code editor

No response

Operating System

No response

Node.js version

No response

TypeScript version

No response

Database type and version

No response

On which device do you see the problem?

Laptop

On which operating system do you see the problem?

Windows

On which browsers do you see the problem?

Microsoft Edge

On what version of the browsers do you see the problem?

119.0.2151.44

Additional information

No response

VictorTomaili commented 8 months ago

This is not a bug; we didn't have such a feature. We'll add to our backlog.

volkanceylan commented 8 months ago

Seems like we had a workaround but it no longer works with Bootstrap 5 as it does not use jquery. This will be re-fixed in 6.9.6