serenity-is / Serenity

Business Apps Made Simple with Asp.Net Core MVC / TypeScript
https://serenity.is
MIT License
2.57k stars 796 forks source link

[Bug report]: BasedOnRowPropertyNameAnalyzer inherited fields #7006

Closed marcobisio closed 8 months ago

marcobisio commented 8 months ago

Before submitting the bug report, please read and check the following items

What happened?

Inherited fields aren't recognised by new BasedOnRowPropertyNameAnalyzer feature (both in form and columns):

image

They belong to the abstract class LoggingRow (similar to https://github.com/serenity-is/common-features/blob/d035f35686ffa79701ee2af73d4fda69a2f47a89/src/Serenity.Extensions/Modules/BaseEntities/LoggingRow.cs#L10) which is implemented by the xyzRow of the image above. Adding IgnoreName attribute is the only workaround that I found right now.

What did you expect to happen?

Form and Columns should recognise also inherited fields.

How to reproduce?

Just create an entity which inherit from LoggingRow and try to add one of the inherited fields to the Form or to the Columns.

What Serenity Nuget Versions are you seeing the problem on? (separated by comma)

6.9.5

Relevant log output

No response

Serene template version

No response

Sergen version

No response

Code editor

No response

Operating System

No response

Node.js version

No response

TypeScript version

No response

Database type and version

No response

On which device do you see the problem?

No response

On which operating system do you see the problem?

No response

On which browsers do you see the problem?

No response

On what version of the browsers do you see the problem?

No response

Additional information

No response

volkanceylan commented 8 months ago

Thanks @marcobisio, fixed and will be released with next version

marcobisio commented 8 months ago

Thanks @volkanceylan !