search

serenity-kit / react-native-libsodium

React Native bindings to Libsodium matching the libsodium-wrappers package API
MIT License
30 stars 9 forks source link

[Expo] Execution failed for task ':react-native-libsodium:buildCMakeRelWithDebInfo[arm64-v8a]' #62

Closed mariomurrent-softwaresolutions closed 8 months ago

mariomurrent-softwaresolutions commented 9 months ago

When building the app locally I'm getting the following error:

[RUN_GRADLEW] FAILURE: Build failed with an exception. [RUN_GRADLEW] * What went wrong: [RUN_GRADLEW] Execution failed for task ':react-native-libsodium:buildCMakeRelWithDebInfo[arm64-v8a]'. [RUN_GRADLEW] > com.android.ide.common.process.ProcessException: ninja: Entering directory '/private/var/folders/zj/kppl1wn13_j6ndc84b1qzb9c0000gn/T/eas-build-local-nodejs/2d00feb0-5c83-4023-8a50-909b1b50b19b/build/node_modules/react-native-libsodium/android/.cxx/RelWithDebInfo/6j1y323g/arm64-v8a' [RUN_GRADLEW] [1/4] Building CXX object CMakeFiles/libsodium.dir/cpp-adapter.cpp.o [RUN_GRADLEW] FAILED: CMakeFiles/libsodium.dir/cpp-adapter.cpp.o

Any idea what's wrong? Or am I missing something installed on my Mac?

nikgraf commented 9 months ago

puhhh absolutely no idea, does it work. I wonder if it's related to the last release. Can you try 1.2.3

mariomurrent-softwaresolutions commented 9 months ago

I already tried the other versions, no change ... Maybe it's an issue with the current EXPO 50 SDK? Or a wrong NDK?

Im getting:

/node_modules/react-native/ReactCommon/jsi/jsi/jsi.h:1107:23: error: no template named 'enable_if_t' in namespace 'std'; did you mean 'enable_if'?

Seems like some incomatiblities?

nikgraf commented 9 months ago

hmmm, I used it with Expo 50 in one project

mariomurrent-softwaresolutions commented 9 months ago

Well that's strange. Do you know with which Android SDK? And NDK?

nikgraf commented 9 months ago

that said just realized I only did the iOS simulator test. The project doesn't support Android yet. So until I need it in the project or someone pays for it I won't make it a priority. Sorry :(

My guess is Expo50 uses a more modern React Native version than the e2e tests in here. So my first move would be to upgrade to the latest react native version and see if it works.

mariomurrent-softwaresolutions commented 9 months ago

Alright - yeah it is working for Expo iOS but not Android

nikgraf commented 9 months ago

just to clarify: happy to accept contributions. just not going to spend half a week or trying to debug it at the moment

landabaso commented 9 months ago

Hi! Thanks for providing this package! I hit the same prob, also using Expo 50. Did you do find any workaround @mariomurrent-softwaresolutions ? Maybe go back to Expo 49?

mariomurrent-softwaresolutions commented 9 months ago

Hi! Thanks for providing this package! I hit the same prob, also using Expo 50. Did you do find any workaround @mariomurrent-softwaresolutions ? Maybe go back to Expo 49?

Going back ist not an option, since EXPO SDK 49 will be deprecated in the future. I searched the enable_if_t in the /node_modules/react-native/ReactCommon/jsi/jsi/jsi.h and replaced it with enable_if

That solve the build at least as a quick fix. But this is just a temporary solution. You can patch the package and it should work, until this is fixed

landabaso commented 9 months ago

Hi! Thanks for providing this package! I hit the same prob, also using Expo 50. Did you do find any workaround @mariomurrent-softwaresolutions ? Maybe go back to Expo 49?

Going back ist not an option, since EXPO SDK 49 will be deprecated in the future. I searched the enable_if_t in the /node_modules/react-native/ReactCommon/jsi/jsi/jsi.h and replaced it with enable_if

That solve the build at least as a quick fix. But this is just a temporary solution. You can patch the package and it should work, until this is fixed

I found a better fix. See the PR.

mariomurrent-softwaresolutions commented 9 months ago

Hi! Thanks for providing this package! I hit the same prob, also using Expo 50. Did you do find any workaround @mariomurrent-softwaresolutions ? Maybe go back to Expo 49?

Going back ist not an option, since EXPO SDK 49 will be deprecated in the future. I searched the enable_if_t in the /node_modules/react-native/ReactCommon/jsi/jsi/jsi.h and replaced it with enable_if That solve the build at least as a quick fix. But this is just a temporary solution. You can patch the package and it should work, until this is fixed

I found a better fix. See the PR.

Thx for investigating and fixing :) Hope this PR will be merged soon

nikgraf commented 8 months ago

Merged it, but now e2e tests are failing for android complaining about the CMake version. I guess that's related. Anyone has time to look into it? I have earliest time in mid march :(

landabaso commented 8 months ago

I can build it for android using yarn example android(there were some warnings but compiles fine in my case) and all the tests passed in the simulator.

Do you want to fix the compilation warnings or are you talking about a different issue? I'm not sure how to reproduce the problem.

Can you try running the tests and confirm @mariomurrent-softwaresolutions ? (you need to follow this: https://github.com/serenity-kit/react-native-libsodium/blob/main/CONTRIBUTING.md)

nikgraf commented 8 months ago

This script was failing on the main branch. I also realized you didn't follow the commit guidlines which makes releasing a bit more tricky.

I force pushed your commit with a new commit message and released (I hope I won't regret this 😅). If one of you has time to investigate it would be great to improve see whats wrong here: https://github.com/serenity-kit/react-native-libsodium/blob/main/.github/workflows/e2e-android.yml

mariomurrent-softwaresolutions commented 8 months ago

@landabaso Well I tried out the new version and its actually building, but the App is not launching anymore ... so it crashes before it even comes up :(

landabaso commented 8 months ago

Hi @mariomurrent-softwaresolutions, that's odd. The library works well in my project. In fact I'm using the released version without issues. Could you share the specific (thrown) error you're encountering?

@nikgraf, could you provide steps to reproduce the issue? The e2e tests for Android seem to be passing as per the workflow here: https://github.com/serenity-kit/react-native-libsodium/actions/workflows/e2e-android.yml

I noticed the workflow corresponding to the Merge for PR #63 was cancelled. Was this manual? Currently, I'm unable to identify any specific errors to address. Any additional information would be helpful. I'm not highly experienced with these workflows, so any additional insights or guidance would come handy.

nikgraf commented 8 months ago

@landabaso yeah, the e2e tests ran fine - so no issue anymore. Seems like it was a hickup in the CI that happened multiple times on this day.

The PR was canceled, because the commit hook was bypassed. So I fixed it and overwrote the commit. All good again. Thanks for identifying and fixing the issue :)

mariomurrent-softwaresolutions commented 8 months ago

@landabaso I don't even figured out what the exact error is ... neither iOS or Android log state very much :(

landabaso commented 8 months ago

@landabaso I don't even figured out what the exact error is ... neither iOS or Android log state very much :(

You modified the sources, right? Try to delete any associated patch-package, completely uninstall the library, install it again and try. Delete the app in the simulator and reinstall the new one. Clear any caches. It should work. The only change applied was using a different compiler version (more modern).

mariomurrent-softwaresolutions commented 8 months ago

Yeah, I already tried this as well ... Maybe I'll give it a try again this week