search

serenity-kit / react-native-libsodium

React Native bindings to Libsodium matching the libsodium-wrappers package API
MIT License
30 stars 9 forks source link

Expose libsodium functionality for Asymmetric Crypto #64

Closed devYonz closed 8 months ago

devYonz commented 8 months ago
devYonz commented 8 months ago

credit to @getify https://github.com/getify/react-native-libsodium/tree/ed25519-to-curve25519

getify commented 8 months ago

this needs the final commit from my branch

nikgraf commented 8 months ago

@yfeleke @getify I'm bit confused by the multiple PRs opened and then closed right. Was this by accident or would you be interested to submit them?

getify commented 8 months ago

@nikgraf apologies, we thought the code in the PR was correct and ready, but further testing showed us it was not working yet.

seems there were some issues with the cpp code, specifically, and return values being empty.

once that's fixed, will re-submit a PR for review/feedback.

devYonz commented 8 months ago

Like Kyle mentioned, we are working on the @getify fork to fix bugs and get ed25591 encryption working. The couple from the weekend were caused because GitHub defaults to the original branch when you try to create a PR for a fork. It is a pretty bad design and I've fallen for it twice this weekend.

In other words, I check out the @getify and push a branch to create a PR to our fork. It defaults to the main repo 😣.

I apologize for what must be an annoying number of GitHub emails. I'll shoot you an email when we fire off the finished PR.

nikgraf commented 8 months ago

@yfeleke @getify btw was the Local first authentication talk recorded yesterday? Is your work related? If you es you might like https://github.com/serenity-kit/opaque & https://github.com/serenity-kit/react-native-opaque (which I think has quite a potential for local first authentication with e2e encryption)

getify commented 8 months ago

Yes it was recorded, should be out soon. :)

We were working on getting the web demo ported to show off the same concepts in a react-native mobile app. Unfortunately we didn't quite get that working for the talk, but we're still hopeful to have that working soon, and then we'll post a PR back here with the updated code. :)

devYonz commented 8 months ago

Hey @nikgraf, will give those a look. Are you interested in helping out with this effort? DM me your discord in LoFi

devYonz commented 7 months ago

Recording is up now: https://www.youtube.com/playlist?list=PLTbD2QA-VMnXFsLbuPGz1H-Najv9MD2-H