.unwrap_or_default() instead of falling back to "<prefix>" in single-command help

serenity-rs / poise

Discord bot command framework for serenity, with advanced features like edit tracking and flexible argument parsing

MIT License

644 stars 114 forks source link

.unwrap_or_default() instead of falling back to "<prefix>" in single-command help #255

Open SIGSTACKFAULT opened 6 months ago

SIGSTACKFAULT commented 6 months ago

fixes #254

kangalio commented 6 months ago

Hi, thanks for the fix! Reading the code comments in the removed code, I would prefer you make the fallback string configurable, bc for dynamic prefixes, an empty string is not a good fallback either

SIGSTACKFAULT commented 6 months ago

@kangalio help_all_commands already falls back to not showing any prefix here so i copied that logic.

I think this whole file would need a bit of a rewrite