serenity-rs / serenity

A Rust library for the Discord API.
https://discord.gg/serenity-rs
ISC License
4.78k stars 583 forks source link

refactor!: remove `fs` feature for `tokio` by default. #2824

Closed UserIsntAvailable closed 7 months ago

UserIsntAvailable commented 7 months ago

I currently working with wasm on one of my personal projects. I'm would like to use serenity to get access to the discord API response models, but currently the library can not the compiled to wasm, because the tokio/fs feature is not supported in that target.

I went ahead and removed the need to include that feature by default. By the looks of it, it only was used with the builder and model features, so I conditionally added tokio/fs back when those features are being used (the model feature already depends on builder so that doesn't need to be changed).

UserIsntAvailable commented 7 months ago

I wasn't aware this was considered breaking. I updated the branch and the title to reflect that :+1:.