Fix null error in InstallationContextConfig

serenity-rs / serenity

A Rust library for the Discord API.

https://discord.gg/serenity-rs

ISC License

4.65k stars 571 forks source link

Fix null error in InstallationContextConfig #2917

Closed ValgulNecron closed 1 month ago

ValgulNecron commented 1 month ago

Added #[serde(default)] to oauth2_install_params in InstallationContextConfig and added a Default implementation to InstallParams #2883 and https://discord.com/developers/docs/resources/application#application-object-application-structure.

mkrasnitski commented 1 month ago

Since CurrentApplicationInfo::integration_types_config is gated behind unstable_discord_api, it's actually ok to break the serenity API and change its oauth2_install_params field to Option<InstallParams>.

ValgulNecron commented 1 month ago

Hi thanks for the info i changed it to an option and removed the change I made before