search

serenity-rs / songbird

An async Rust library for the Discord voice API
ISC License
381 stars 108 forks source link

Make DisposalThread reachable #235

Closed AlvaroMS25 closed 3 months ago

AlvaroMS25 commented 3 months ago

The Config object provided to Calls and Drivers allows setting a DisposalThread, but since it is unreachable from outside the crate, the only way to properly set it is using a Songbird instance, which may not be adequate for all use cases. This PR just makes DisposalThread reachable from the outside.

AlvaroMS25 commented 3 months ago

I'm sorry about that, i didn't realize how much i was making public with that. You're right, just doing a pub use would be enough. I'll update this PR in a sec

FelixMcFelix commented 3 months ago

Fantastic, thanks very much!