Caddy Docker Proxy + Sablier

serfriz / caddy-custom-builds

Caddy Docker custom images built with different combinations of modules. All images are updated automatically when a new version of Caddy is released.

GNU General Public License v3.0

53 stars 9 forks source link

Caddy Docker Proxy + Sablier #12

Closed accforgithubtest closed 5 months ago

accforgithubtest commented 5 months ago

Hello !

I would like a Caddy build with the following modules:

Thank you for this project !

serfriz commented 5 months ago

Hey! No problem, I'll add it later today!

accforgithubtest commented 5 months ago

thanks you @serfriz , much appreciated !

serfriz commented 5 months ago

I was looking at the modules you requested after editing your first message, and some of them aren't maintained and/or mentioned in Caddy's docs. To make sure I don't create unsafe or broken Caddy builds, I would prefer if the modules included could be found in the list from Caddy's download page.

Regarding your list:

caddy-docker-proxy: listed in Caddy's download page, so this module is fine.
Sablier: this is tricky because it's not listed in Caddy's download or docs pages, but I saw it's is a well maintained project so I am willing to make an exception.
Rate Limit: not maintained, but a equivalent one that meets the criteria would be mholt/caddy-ratelimit
IP Filter: not maintained and not compatible with Caddy v2, in any case Caddy v2 already has that functionality built-in. There are also various geo-location filter modules.
NoBots: doesn't meet the criteria and it doesn't look maintained and/or compatible with Caddy v2. Let me know if you find an alternative, but similar functionality can probably be achieved with Caddy's built-in directives.

With that being said, what modifications would you like to make to your request?

accforgithubtest commented 5 months ago

Hi @serfriz - Thank you for your response.

I am a beginner level self-hoster just trying to find my ways around what functionalities would be useful. So I really appreciate your detailed response / reasoning and I am also learning from your comment on what to look for when choosing these software !

Happy to go with your suggestions, to -

Keep caddy-docker-proxy and Sablier in this request.
Use mholt/caddy-ratelimit
Exclude NoBots and IPFilter.

Thank you again for your detailed response and your generosity in making these custom builds !

serfriz commented 5 months ago

You are welcome! I had a question about how to correctly include Sablier in the build because I think the documentation is slightly outdated, so I asked about it in Sablier's repository just to make sure.

acouvreur commented 5 months ago

Hello @serfriz !

Thanks for the input on the Sablier page :)

Sablier: this is tricky because it's not listed in Caddy's download or docs pages, but I saw it's is a well maintained project so I am willing to make an exception.

About this, any information on how to get my module listed on the official documentation ?

serfriz commented 5 months ago

Hello @serfriz !

Thanks for the input on the Sablier page :)

Sablier: this is tricky because it's not listed in Caddy's download or docs pages, but I saw it's is a well maintained project so I am willing to make an exception.

About this, any information on how to get my module listed on the official documentation ?

You are welcome! As far as I know there is a process to register new community modules, you can find some instructions here: https://caddyserver.com/docs/extending-caddy#module-documentation

serfriz commented 5 months ago

Hey @accforgithubtest , I just pushed the build caddy-ratelimit-dockerproxy-sablier, the Docker should be ready in an hour or so. In the future I'll work on improving the instructions of the container, for now I just referenced the documentation of the different modules.

Please, let me know if you have any issues.

accforgithubtest commented 5 months ago

Thanks a lot @serfriz ! Really appreciate it and will give this a try in the next few days.

accforgithubtest commented 4 months ago

hi @serfriz - I am now trying to test out this container and wanted to ask you if the Dockerfile in this repo needs to also include the sablier start commands mentioned in this sablier docs

This projects dockerfile only seems to be starting up docker-proxy and caddy, but not sablier ?

I tried providing the below command in the docker compose file for trying to get sablier also started and get the below error in logs

command:
      - start
      - --provider.name=docker

Logs:

Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "start": executable file not found in $PATH: unknown

serfriz commented 4 months ago

Hey @accforgithubtest, did you follow these steps using the Docker image from this repository instead of "caddy:2.6.4-with-sablier"?

Using Caddy with the Sablier plugin doesn't mean you don't have to run Sablier itself too, so in your Docker compose you should also add Sablier Docker (with that start command). The Sablier plugin for Caddy just enables Sablier Docker to communicate with Caddy Docker.

accforgithubtest commented 4 months ago

I was under the assumption that i don't need to run sablier, as it is bundled with caddy here - I have missed a critical piece of info/understanding. Thank you for clarifying that, will get sablier running as well and see how it goes. Thanks again !