search

sergdort / CleanArchitectureRxSwift

Example of Clean Architecture of iOS app using RxSwift
MIT License
3.88k stars 494 forks source link

Removed pods from repository. Updated to Swift 4.2 #54

Closed piotrtorczynski closed 5 years ago

piotrtorczynski commented 5 years ago

Hello, I really like your job with this repository.

I decided to update it to newest version with swift 4.2 and Xcode 10.

I also decided to get rid off pod folder in repository because amount of libraries that have changed was really big. Now everyone can benefit from Podfile.lock file and get newest version.

I also introduced mapping with Codable protocol instead of ObjectMapper which seems to be redundant dependencies with Swift 4.

If you would like to keep dependencies in repository we can do this if necessary. :)

andreabozza1984 commented 5 years ago

thnx

sergdort commented 5 years ago

Hi, thank you very much!

Not sure tho, if it's a good idea to remove pods from the repo.

sergdort commented 5 years ago

But, I don't really mind ¯_(ツ)_/¯