search

sergdort / CombineFeedback

Unidirectional reactive architecture using new Apple Combine framework https://developer.apple.com/documentation/combine
MIT License
688 stars 54 forks source link

Is Builder intended to be included in the library? #20

Closed kaishin closed 4 years ago

kaishin commented 4 years ago

Following the examples in my own project, I realized that the Builder helper protocol is not part of the library. Is that an oversight or should I just copy the set method directly in my own project?

sergdort commented 4 years ago

Hey @kaishin I've now changed Reducer signature from (State, Event) -> State to be (inout State, Event) -> Void so there is no need for Builder helper anymore, just make properties of your State struct var is they intent to be mutable

kaishin commented 4 years ago

Thanks!

Feel free to close or leave the issue open as you see fit.