search

serge-community / serge

Continuous localization platform
https://serge.io/
Other
236 stars 52 forks source link

Update parse_resx.pm #123

Closed matspursche closed 4 years ago

matspursche commented 5 years ago

I needed to add the key as a 6th property to get this to work in the latest release. Please verify if it's the right way to solve this.

codecov-io commented 5 years ago

Codecov Report

Merging #123 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   54.76%   54.76%           
=======================================
  Files          94       94           
  Lines        6997     6997           
  Branches     1739     1739           
=======================================
  Hits         3832     3832           
  Misses       2494     2494           
  Partials      671      671
Impacted Files Coverage Δ
lib/Serge/Engine/Plugin/parse_resx.pm 92.85% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e5ddb0e...3f77671. Read the comment docs.

iafan commented 4 years ago

I made the change in https://github.com/evernote/serge/commit/4928045322a32f528d20f8bdb64b9f696c0beee1

Since the change was tiny, and in your PR we'd need to remove a commented out line and rename variables, I thought it would be much quicker to land the commit with proper fixes myself. But your approach on passing the extra parameter was correct.