AtnNn commented 4 years ago

Adds supports for strings like these which I've added to the tests:

    IDS_CURRENCY L"Euro (\x20AC)"
    IDS_ANGLE  L"180\x00B0"

These are documented here: https://docs.microsoft.com/en-us/windows/win32/menurc/stringtable-resource

Thanks!

codecov-commenter commented 4 years ago

Codecov Report

Merging #129 into master will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   54.05%   54.08%   +0.02%     
==========================================
  Files          98       98              
  Lines        7242     7246       +4     
  Branches     1788     1789       +1     
==========================================
+ Hits         3915     3919       +4     
  Misses       2652     2652              
  Partials      675      675

Impacted Files	Coverage Δ
lib/Serge/Engine/Plugin/parse_rc.pm	`90.27% <100.00%> (+0.57%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ed911c...7eb435e. Read the comment docs.

iafan commented 3 years ago

@AtnNn thanks for the contribution! I added you to the contributors list: https://github.com/evernote/serge/blob/master/AUTHORS#L13

Let me know if you want to put some other link or email there.

serge-community / serge

Parse L-strings and escape codes in RC files #129

Codecov Report