Open iafan opened 4 years ago
@iafan By plurr we mean this: https://github.com/loctools/plurr ?
@benjamimo1 correct!
If we input all necessary strings:
If we don't:
Is "Empty string rendered" a different case scenario as "Please enter placeholder"? Are we aiming for two different message for each scenario? I don't understand how they are different. Or should I just change the message altogether without a change in logic? Or are we aiming for a partial rendering of the message using all inputs so far. Do we consider the 0 value as an empty string? (Given the example you provided) or are we talking about #472
Yes, these are different cases. The first one is when you have missing (empty) placeholder values. The second one is an empty string as returned from Plurr formatting function.
In your screenshot above, you will never get an empty string in the output, regardless of the parameters. But there can be units which may produce an empty string as an output. See this example (try to change N to 0
, 1
, and 2
)
OK, will give it a look now, assuming two different cases.
When the rendered string is empty, let's provide a different message, e.g. "Empty string rendered", rather than saying "Please enter placeholder <...>" (see the screenshot)