Closed aameen951 closed 5 years ago
I'm trying to modify Milton to add grid tool for handmade hero to draw pixel-grid.
I found things that seem old/dead code. I'll list them just in case I'm missing something important.
https://github.com/serge-rgb/milton/blob/e369c5eaeb12deabad5af9e86b78023f9a693210/src/gui.cc#L303-L304
https://github.com/serge-rgb/milton/blob/e369c5eaeb12deabad5af9e86b78023f9a693210/src/gui.cc#L311-L312
The following line is redundant because copy_stroke does copy the brush. https://github.com/serge-rgb/milton/blob/e369c5eaeb12deabad5af9e86b78023f9a693210/src/milton.cc#L1506
Why calculating the BB of the stroke twice then union them? https://github.com/serge-rgb/milton/blob/e369c5eaeb12deabad5af9e86b78023f9a693210/src/milton.cc#L1508-L1509
I'm trying to modify Milton to add grid tool for handmade hero to draw pixel-grid.
I found things that seem old/dead code. I'll list them just in case I'm missing something important.
https://github.com/serge-rgb/milton/blob/e369c5eaeb12deabad5af9e86b78023f9a693210/src/gui.cc#L303-L304
https://github.com/serge-rgb/milton/blob/e369c5eaeb12deabad5af9e86b78023f9a693210/src/gui.cc#L311-L312
The following line is redundant because copy_stroke does copy the brush. https://github.com/serge-rgb/milton/blob/e369c5eaeb12deabad5af9e86b78023f9a693210/src/milton.cc#L1506
Why calculating the BB of the stroke twice then union them? https://github.com/serge-rgb/milton/blob/e369c5eaeb12deabad5af9e86b78023f9a693210/src/milton.cc#L1508-L1509