search

serge-rgb / milton

An infinite-canvas paint program
GNU General Public License v3.0
1.53k stars 133 forks source link

Fix #136 clamp brush size to 1..300 #139

Closed gonutz closed 5 years ago

gonutz commented 5 years ago

While holding shift and dragging the mouse left/right to change the brush size, the size previoulsy was able to become negative/very large. This change clamps it to 1..300, just like the GUI slider.

gonutz commented 5 years ago

Oh, I did not realize there was a clamp function :-)

Thanks for merging my PRs. Off-topic for this issue I would like to ask your quick opinion about keyboard input. The reason I originally started working on your code base was the idea to have a special text input mode. At work I do not have a tablet and we used Milton for some discussions. Drawing text with the mouse however turned out to be very troublesome. It looks bad and is slow to input. That is why I am currently working on a Text mode where you have a text cursor and typing in that mode will "write" with a stroke font until you hit Esc to go back to brush mode.

My question is, are you at all interested in this feature, should I create an issue for it and start discussing there? As I said, I will create the feature anyway but your readme specifically states what Milton is not (not Inkskape etc.) so I wanted to quickly poll you opinion on it.