On macOS the file objc/objc.h defines macros YES and NO as part of the Objective-C BOOL type definition. Milton also defines its own YesNoCancelAnswer enumeration type containing values YES and NO.
On macOS this causes a conflict where the compiler attempts macro expansion on the definitions of YesNoCancelAnswer::YES and YesNoCancelAnswer::NO. This leads to compilation failure.
To fix this failure, this change renames the constants of YesNoCancelAnswer from YES to YES_, NO to NO_, and for consistency from CANCEL to CANCEL_. All occurrences of the previous constants are replaced.
In addition, this change adds the required function platform_dialog_yesnocancel to src/platform_mac.mm. This displays a Yes/No/Cancel dialog box on macOS and returns the users response.
TESTED
[X] Compiles on macOS Mojave (v10.14.6) without error.
serge-rgb
commented
5 years ago
DESCRIPTION Closes #149
On macOS the file
objc/objc.hdefines macrosYESandNOas part of the Objective-CBOOLtype definition. Milton also defines its ownYesNoCancelAnswerenumeration type containing valuesYESandNO.On macOS this causes a conflict where the compiler attempts macro expansion on the definitions of
YesNoCancelAnswer::YESandYesNoCancelAnswer::NO. This leads to compilation failure.To fix this failure, this change renames the constants of
YesNoCancelAnswerfromYEStoYES_,NOtoNO_, and for consistency fromCANCELtoCANCEL_. All occurrences of the previous constants are replaced.In addition, this change adds the required function
platform_dialog_yesnocanceltosrc/platform_mac.mm. This displays a Yes/No/Cancel dialog box on macOS and returns the users response.TESTED