search

serge-rgb / milton

An infinite-canvas paint program
GNU General Public License v3.0
1.53k stars 133 forks source link

Add support for rectangles and grids #158

Closed alexpana closed 4 years ago

alexpana commented 4 years ago

This was requested by Casey Muratori in a handmade hero video, and I had a little spare time.

https://youtu.be/Yu8k7a1hQuU?t=3380

alexpana commented 4 years ago

I also recorded myself fumbling thorugh the code for the first time and implementing the PR: https://www.youtube.com/watch?v=Kfx1MrE6s8Q

serge-rgb commented 4 years ago

Hey,

Thanks for doing this, Just one thing. Rectangles should probably work with rotation so that the sides are always parallel to the screen. Currently this feature generates rotated triangles when the view is rotated. Would you be willing to implement this on top of what you have already done?

alexpana commented 4 years ago

Hello,

Thanks for the response. I don't have much experience using milton so I didn't take into account all the ways it could be used.

I'll try to have a look at it this week.

serge-rgb commented 4 years ago

No worries, it's an easy thing to miss. Otherwise, it looks like a good change.

Thanks a lot! Let me know if I can help

-Sergio

On Tue, Jan 7, 2020 at 4:16 AM Alexandru Pană notifications@github.com wrote:

Hello,

Thanks for the response. I don't have much experience using milton so I didn't take into account all the ways it could be used.

I'll try to have a look at it this week.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/serge-rgb/milton/pull/158?email_source=notifications&email_token=AACFCWQPJFQAHIWW7CFYFXLQ4RXC3A5CNFSM4J2YFMY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIIVZMY#issuecomment-571563187, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACFCWWHCUFVFSG75SSLXU3Q4RXC3ANCNFSM4J2YFMYQ .