serge-rgb / milton

An infinite-canvas paint program
GNU General Public License v3.0
1.53k stars 133 forks source link

Fix platform_windows broken since #190 extern "C" fix for platform_unix #200

Closed gavinbeatty closed 2 years ago

gavinbeatty commented 2 years ago

win32_log and win32_log_args were not declared extern "C" even though they were defined extern "C".

Without the fix, build.bat has the following errors:

src\platform_windows.cc(372): error C2732: linkage specification contradicts earlier specification for 'win32_log'
src\platform_windows.cc(371): note: see declaration of 'win32_log'
src\platform_windows.cc(383): error C2732: linkage specification contradicts earlier specification for 'win32_log_args'
src\platform_windows.cc(382): note: see declaration of 'win32_log_args'

Apologies, this was introduced by me when fixing Linux builds in #190.

serge-rgb commented 2 years ago

Thanks for the fix!