serge-sans-paille / frozen

a header-only, constexpr alternative to gperf for C++14 users
Apache License 2.0
1.27k stars 103 forks source link

Warning concerning a missing constexpr #122

Closed tetsuhaut closed 3 years ago

tetsuhaut commented 3 years ago

In file include/frozen/random.h, line 55,

if(modulus != 0)

should read

if constexpr (modulus != 0)

I tried to make a pull request but couldn't due to a 403 error.

serge-sans-paille commented 3 years ago

frozen is written in c++14 where if constexpr is not supported. I'll use another approach.

serge-sans-paille commented 3 years ago

Can you confirm #128 fixes your issue? Thanks!

tetsuhaut commented 3 years ago

Works great :)