search

serge-sans-paille / frozen

a header-only, constexpr alternative to gperf for C++14 users
Apache License 2.0
1.27k stars 103 forks source link

feature: deduction guides for sets #131

Closed impugachev closed 2 years ago

impugachev commented 2 years ago

The guides will allow to create variables like this:

constexpr frozen::set integersSet{1,2,3,4,5};
serge-sans-paille commented 2 years ago

Sorry for the delay, I somehow missed that PR :-/ I like the idea, and I'm happy we add contribution guides to frozen.

serge-sans-paille commented 2 years ago

I'll setup CI for C++17 and ping you so that you rebase your PR on master, does that sound like a good plan?

serge-sans-paille commented 2 years ago

Can you rebase on #133 ? If it works fine, I'll merge #133 then #131

impugachev commented 2 years ago

Can you rebase on #133 ? If it works fine, I'll merge #133 then #131

Done and it works

serge-sans-paille commented 2 years ago

I had to update my CI PR, can you apply the change? thanks and sorry for the back and forth

serge-sans-paille commented 2 years ago

Manually merged in 3cbcda97851d1486b593721e6b1035fa1f51a65a Thanks a lot o/ Would you mind doing the same work for maps?

impugachev commented 2 years ago

Would you mind doing the same work for maps?

@serge-sans-paille I don't remember anymore, but I think I tried to do it and ran into some problem... But I'll try again.

impugachev commented 2 years ago

And yes, this cannot be done for the map, because at least it is impossible to deduce the size from initializer_list. Existing make_ functions are more than enough