Closed impugachev closed 2 years ago
@serge-sans-paille could you please take a look?
Thanks for the patch - I'm fine with the idea. I'll add C++20 to the validation then you can add a test to make sure this indeed works fine.
Validation now supports c++20. You can test with std::string container on C++20. Please rebase on master
branch ;-)
I'm not quite sure what test to write here, so as not to fall into testing the obvious things ... Therefore, I added just one simple test to check compilation
I was thinking about testing, say, a frozen::set
of std::string
. That's what we want in the end, right?
Ok, I will then add a typed test for searching in frozen containers
Looks good, can you rebase on master
branch and squash all your commits in one?
Done @serge-sans-paille, can you please merge?
Thanks for your patience o/
This will allow using frozen containers with
std::string_view
(C++17) andstd::string
(C++20). I'm not sure if tests are needed for this ... I plan to add a heterogeneous search in the next PR, there it will already be possible to write tests that will use the hash forstd::string_view
.