search

serge-sans-paille / frozen

a header-only, constexpr alternative to gperf for C++14 users
Apache License 2.0
1.27k stars 103 forks source link

feature: heterogeneous lookup for ordered containers #141

Closed impugachev closed 2 years ago

impugachev commented 2 years ago
  1. Deleted useless is_transparent from map.
  2. Fixed type safety of map.
  3. Added heterogenous lookup for set.

CompareKey isn't overcomplication, as I said before. It's an adaptor for bound functions, so that there is no need to write additional overloads.

impugachev commented 2 years ago

Also, can we release a new version after this PR?

serge-sans-paille commented 2 years ago

You can probably remove detail::is_transparent now.

serge-sans-paille commented 2 years ago

Did I understand correctly that you mean a test that will check that make_set makes the same objects from a C array and std::array? Or just the same test as this, only with initialization from C array?

both :-)

impugachev commented 2 years ago

OK, update:

  1. Deleted type_traits with unused void_t and is_transparent.
  2. Made tests for make_set more explicit.
  3. Added second set to transparency test.
serge-sans-paille commented 2 years ago

Thanks!

serge-sans-paille commented 2 years ago

(release done, tagged as 1.1.0)