search

serge-web / map

Mapping component used in Serge wargaming environment.
https://serge-map.herokuapp.com/index.html
Apache License 2.0
1 stars 0 forks source link

Debugging mode #17

Closed IanMayo closed 5 years ago

IanMayo commented 5 years ago

I think that at least once, and maybe repeatedly, we should aim to verify the coordinates provided by the map match those that were clicked on.

Beyond that, there may be instances when messages refer to hex cells. Ideally spatially-related messages will, at some point in the future, allow a marker to be displayed on the map (sea-mine found, stranded yacht, etc). But, until then, maybe the UI should allow hex cell id numbers (coordinates) to be displayed - possibly via a checkbox.

BMPMS commented 5 years ago

Markers and paths are always placed on the hex map relating the hex id (row-column). They always match because all the clicks are related to the hex’s which have their set id. Their ‘center' is defined and stored on initialise and is always accessed via the same function (get_points).

Should the map be redrawn (potentially on window resize), the new ‘center’ points can be stored and we are ready to go.

What I do need to do (doing now) is to make all instances of placing the icon in one function as there is an offset from the center which is currently repeated a couple of times (and has caused the error). Slap on the wrist, sorted.

It would be a 10 minute job to add a function to place a marker on a given hex.

On 13 Mar 2019, at 10:40, Ian Mayo notifications@github.com wrote:

I think that at least once, and maybe repeatedly, we should aim to verify the coordinates provided by the map match those that were clicked on.

Beyond that, there may be instances when messages refer to hex cells. Ideally spatially-related messages will, at some point in the future, allow a marker to be displayed on the map (sea-mine found, stranded yacht, etc). But, until then, maybe the UI should allow hex cell id numbers (coordinates) to be displayed - possibly via a checkbox.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/serge-web/map/issues/17, or mute the thread https://github.com/notifications/unsubscribe-auth/ARwFYtcTx9DWNfiMBy3J3HkykU65HISFks5vWNW2gaJpZM4bs6Ee.