search

serge-web / serge

Serious Gaming, Evolved - web interface
https://sites.google.com/deepbluec.com/serge/
Apache License 2.0
14 stars 4 forks source link

Reactive Online Marker #1389

Closed ShendMikullovci closed 2 years ago

ShendMikullovci commented 2 years ago

The online/offline marker is reactive to the text box next to it. It squeezes or expands depending on if the text box says "a few seconds ago" or "X minutes ago".

A Few Seconds Ago Bug

A Minute Ago Bug

Could we make the text box a two-liner so it doesn't impact the marker?

ShendMikullovci commented 2 years ago

Wondering whether it's a font issue? I noticed that the Role and Last Active fonts might not be the same:

Role Font Message Channel

Last Active Font Message Channel

Also, apparently, Chrome considers the offline marker as the same element as the text box. Maybe they need to be separate?

IanMayo commented 2 years ago

Another solution is to take more control of the column widths. I'm sure we can reduce Force and Sent at. Hmm, or we make the dialog 50px (approx) wider. Then the Last active column will fit without squashing the icon.

lebaphi commented 2 years ago

I think the simple solution is set the min-width for the marker, it does not touch too much on the component code based 🤔

lebaphi commented 2 years ago

the marker works well but the text seems to be cut off. we can increase the column width a bit but I wonder if other columns has the long text, so we should support responsive column width here 🤔

image
ShendMikullovci commented 2 years ago

I was playing around with the deployment in #1407 and I noticed that the Message column has the smallest text box info. I thought maybe we could shrink that one, but then I noticed this:

I sent a message with BLUE 1 CO on the Message Channel (VHF C16):

Message Channel Blue 1 CO

The player log seems to show that a message has been sent in "Chat", the same as when a message is sent in the general chat:

Player Log Message Column Shows Chat instead of VHF C16

I would assume that when a player sends a message in the channels, it's a different item than the general chat message? In this example, should we show "VHF C16" in the message column in the player log?

IanMayo commented 2 years ago

I understand the confusion @ShendMikullovci

We are displaying the message-type rather than the channel. So, the game you're looking at has the VHF C16 and Admin both configured to send Chat messages. We could switch to showing the channel name instead, but right now I don't think there is a right answer. I suggest we live with it for a while and see.