search

serge-web / serge

Serious Gaming, Evolved - web interface
https://sites.google.com/deepbluec.com/serge/
Apache License 2.0
14 stars 4 forks source link

Can not sort at 'Last Msg' column on 'Player Logs' table #2861

Closed lebaphi closed 4 months ago

lebaphi commented 7 months ago

Fixes #2855

Tristina1788 commented 7 months ago

Checking on '2855-sort-player-logs' branch, issue sorting on 'Last Msg' is still happened

https://github.com/serge-web/serge/assets/107697044/06006634-60ce-4800-b6d2-47305839b549

@lebaphi Could you check again?

IanMayo commented 7 months ago

Yes, @lebaphi - this is still breaking. It is breaking because the sort() method is receiving a react fragment, which doesn't not support the toLowerCase() method.

Here I output the value of str1 before the .toLowercase() method gets called: image

Tristina1788 commented 5 months ago

Checking on '2855-sort-player-logs' branch, issue sorting on 'Last Msg' is still happened

Can.not.sort.at.Last.Msg.mp4 @lebaphi Could you check again?

@IanMayo The issue still happens on my testing.

lebaphi commented 5 months ago

Ok @lebaphi - it seems this issue is still present: #2861 (comment)

okay, I'm looking on this @IanMayo

Tristina1788 commented 5 months ago

@lebaphi @IanMayo Now I can sort column on 'Player Logs' without issue

https://github.com/serge-web/serge/assets/107697044/839c022d-32e5-497b-8d5b-daa44327df81

Tristina1788 commented 4 months ago

@IanMayo I think it was done. Should we merge to develop and close it?