Properties should not saved when it was cancel before - Githubissues

serge-web / serge

Serious Gaming, Evolved - web interface

https://sites.google.com/deepbluec.com/serge/

Apache License 2.0

14 stars 4 forks source link

Properties should not saved when it was cancel before #2906

Closed lebaphi closed 5 months ago

lebaphi commented 5 months ago

Fixes #2905

Tristina1788 commented 5 months ago

@lebaphi , @IanMayo Tested on '2905-property-save-issue'

Now the properties is not fixed after click 'Cancel'

https://github.com/serge-web/serge/assets/107697044/620a4e9f-586e-4878-8638-34df9a292bc5

I have another case and we should fix it. The properties on a item should not saved when I click to another item (More details on below steps)
1. Click on a item
2. Update any property of this item
3. Click to another item
4. Update any property and save
5. Notice the property is also saved with first item

Expected : Should only save for selected item.

https://github.com/serge-web/serge/assets/107697044/a28f62e6-05a3-4fa5-a619-312ba90dc9bc

@IanMayo How do you think?

Tristina1788 commented 5 months ago

@lebaphi , @IanMayo Now Properties are only saved for selected item as expected.

https://github.com/serge-web/serge/assets/107697044/4d1975bb-a9f1-4828-8b14-5528a39aa346