search

serge-web / serge

Serious Gaming, Evolved - web interface
https://sites.google.com/deepbluec.com/serge/
Apache License 2.0
14 stars 4 forks source link

Should not allow user update 'Health' with invalid value #2911

Closed lebaphi closed 4 months ago

lebaphi commented 5 months ago

Fixes #2909

Tristina1788 commented 4 months ago

@lebaphi I can input the number < 0 and > 100 . I think we should not. @IanMayo How do you think?

image

image

IanMayo commented 4 months ago

@lebaphi I can input the number < 0 and > 100 . I think we should not. @IanMayo How do you think?

Nice observation @Tristina1788 , but we don't actually specify limits for number-properties - I just included it in the description as a hint. We may extend to include that in the future, but it's not a current requirement.

Here is what we specify: image

Tristina1788 commented 4 months ago

@lebaphi I can input the number < 0 and > 100 . I think we should not. @IanMayo How do you think?

Nice observation @Tristina1788 , but we don't actually specify limits for number-properties - I just included it in the description as a hint. We may extend to include that in the future, but it's not a current requirement.

Here is what we specify: image

Now I can see the hint for 'Health' as expected.

image