Update storybook from v6 to v8

serge-web / serge

Serious Gaming, Evolved - web interface

https://sites.google.com/deepbluec.com/serge/

Apache License 2.0

14 stars 4 forks source link

Update storybook from v6 to v8 #2936

Closed lebaphi closed 3 months ago

lebaphi commented 3 months ago

Fixes #2935

Tristina1788 commented 3 months ago

@lebaphi @IanMayo I get this error when running 'yarn build' but seem system still works as normal

I also see it from the github running for building project. So we can ignore the error?

Checking version of story book and now it's updated to 8.x

I can see some news data on this storybook and also found errors on some pages

....

@IanMayo Should I put all error on this PR or I can create another issue for these error?

lebaphi commented 3 months ago

I think these errors happened in v6 @Tristina1788 @IanMayo , so we can rule them out like we did before.

Tristina1788 commented 3 months ago

I think these errors happened in v6 @Tristina1788 @IanMayo

They're new parts from storybook 8.x. I don't see it on 6.x

lebaphi commented 3 months ago

I think these errors happened in v6 @Tristina1788 @IanMayo

They're new parts from storybook 8.x. I don't see it on 6.x

We excluded them in version 6 so that's why you can't see it

Tristina1788 commented 3 months ago

Sorry, seems I click wrong button make the PR close. So I reopen it.

IanMayo commented 3 months ago

Hello @philb89 - I've pulled this branch, done yarn install then yarn storybook. When storybook opened, I saw this error:

I then scrolled back up the terminal, and found this:

These are in the devDependencies section of the root package.json. The lines are new for this PR.

It looks-like I should delete them. Any suggestions?

IanMayo commented 3 months ago

Hello @philb89

(earlier issue hidden, I hadn't pulled all changes)

Current issue is that the Heroku build is failing. It works fine locally, but can't find storybook on Heroku hosting:

I think I see possible related changes in package.json:

Tristina1788 commented 3 months ago

Checked on the latest code on this branch, I can deploy local without issue. And Storybook is on version 8.x as expected.

IanMayo commented 3 months ago

Thanks @Tristina1788 - the current issue is that Storybook isn't provided in Heroku. Being able to review a new feature vai Storybook on Heroku (without having to do a local build) is a really convenient project capability for me.

IanMayo commented 3 months ago

Now Storybook is up and running on Heroku. - https://serge-2935-update-story-2tde1i.herokuapp.com/storybook/

Perfect, thanks @lilitkarapetyan .

I'm sure @lebaphi wants to thank you, too ;-)