serge-web / serge

Serious Gaming, Evolved - web interface
https://sites.google.com/deepbluec.com/serge/
Apache License 2.0
14 stars 4 forks source link

After send message from Collab Channel, I don't see message shows on board or anywhere else #2941

Closed Tristina1788 closed 3 months ago

Tristina1788 commented 3 months ago

🐞 Bug description

After send message from Collab Channel, I don't see message shows on board or anywhere else

🔢 Steps to Reproduce

  1. Create a basic game with some force and some channels
  2. Login from admin page
  3. Click on dropdown of button 'Add Channel'
  4. Select 'Collab Edit'
  5. Add New permission : Blue - All - Edit Collab

image

  1. Play game with Blue - CO
  2. Select 'Collab' Channel, send a message
  3. Notice the new message is not showed on the board or anywhere

⚙️ Expected behavior

🖥️ Screencast

https://github.com/serge-web/serge/assets/107697044/68f3cff0-2496-4c78-a761-84a2555ff204

💻 System information

📝 Additional context

IanMayo commented 3 months ago

Hello @Tristina1788 - it appears you have now been able to send a message. Does that mean that #2940 is not now an issue?

Tristina1788 commented 3 months ago

Hello @Tristina1788 - it appears you have now been able to send a message. Does that mean that #2940 is not now an issue?

I think it's better if we don't show the panel message for the user with permisssion 'Cannot collaborate' . So user will not confuse why they can see the message panel and 'Send' button. @IanMayo How do you think?

IanMayo commented 3 months ago

Hello @lilitkarapetyan

I've created a branch with demo data to test this, it's in PR #2942

If you login as blue player you will see the channel, and create a message. But, when you press [Send], the network tab in Dev-Tools does not show a new message being sent.

IanMayo commented 3 months ago

I think it's better if we don't show the panel message for the user with permisssion 'Cannot collaborate' . So user will not confuse why they can see the message panel and 'Send' button. @IanMayo How do you think?

No, there is logic in it - some roles can submit messages, but not interact with them afterwards.

Tristina1788 commented 3 months ago

I think it's better if we don't show the panel message for the user with permisssion 'Cannot collaborate' . So user will not confuse why they can see the message panel and 'Send' button. @IanMayo How do you think?

No, there is logic in it - some roles can submit messages, but not interact with them afterwards.

If it works as our expected. I think we can close #2940

IanMayo commented 3 months ago

This is fixed in the PR for #2942

Tristina1788 commented 3 months ago

This is fixed in the PR for #2942

Checked on '2941_send_collab_message', I can see the message on the board of Collab channel as expected.

image

IanMayo commented 3 months ago

Fixed in #2942