Introduce blue collab channel

IanMayo commented 3 months ago

Supports #2941

Setup data to test use of collab channel

IanMayo commented 3 months ago

Hello @lilitkarapetyan - I think I'm making good progress here. The messages now expand properly (we had some invalid data in channel definition).

But, when I try to Claim a document, I'm pretty sure the database operation happens ok, but the template doesn't become editable.

Aah, in the console, I do see a warning for duplicate message id:

Maybe we're keeping the old version, but not switching to the new one. Maybe the error is in there.

Yes! that was the error. I think collab editing is working in this branch. @Tristina1788 - you should be able to test the various state changes in the flow-chart in that presentation.

Tristina1788 commented 3 months ago

@IanMayo @lilitkarapetyan

Text 'Chat' and 'Response' are hard to see. And When message still haven't had response yet, it shows as the white long button. It makes user don't know what it is

=> Text 'Chat' and 'Response' should be bold and white color as 'Feedback' text. And when message doesn't have response, we should not show that part.

With below requirement

Message with status 'InProgress' (Edit), user role 'CanSubmitForReview'should has button 'Submit for review', 'Save'

Message with status 'InProgress' (Edit), user role 'CanApproved' should has button 'Save', 'Submit for review'

Message with status 'InProgress' (Edit), user role 'CanRelease' should has button 'Save', 'Submit for review', 'Release'

Message with status 'InProgress' (Edit), user role 'CanUnClaim' should has button 'Save', 'Submit for review', 'Release','Unclaim

I think we have 2 status 'Pending' and 'Review' but now I see it has 'Pending Review'

@IanMayo What is the correct one?

The UI is quite messing and it's hard to follow the action

https://github.com/serge-web/serge/assets/107697044/e0f411c6-2a48-4edf-9914-ee61180b8d31

Here 's config for 'Collab Channel' for more details :

lilitkarapetyan commented 3 months ago

Hello @IanMayo , When we make changes to the collabChannel, the edit message doesn't appear right away. We have to refresh the page for it to show. The problem is that we overlook messages with the same IDs in the changes function. Screenshot (289)

IanMayo commented 3 months ago

Hello @IanMayo , When we make changes to the collabChannel, the edit message doesn't appear right away. We have to refresh the page for it to show. The problem is that we overlook messages with the same IDs in the changes function. !

Great - thanks for spotting that @lilitkarapetyan - that was the next issue for me to work on :-D

I guess it's a similar fix to this one: https://github.com/serge-web/serge/pull/2942/files#diff-d7caf9817cf78f3a3c1767872426b69f6414014447896ebcc7e0b23150422551R75

Would you mind fixing it please?

lilitkarapetyan commented 3 months ago

Hello @IanMayo , When we make changes to the collabChannel, the edit message doesn't appear right away. We have to refresh the page for it to show. The problem is that we overlook messages with the same IDs in the changes function. !

Great - thanks for spotting that @lilitkarapetyan - that was the next issue for me to work on :-D

I guess it's a similar fix to this one: https://github.com/serge-web/serge/pull/2942/files#diff-d7caf9817cf78f3a3c1767872426b69f6414014447896ebcc7e0b23150422551R75

Would you mind fixing it please?

I belive I've resolved it using teh changes function - https://github.com/serge-web/serge/pull/2942/commits/e7ff7d2b0574885dbf0449ee6d99895fb701f0bf

IanMayo commented 3 months ago