We need to fix some remaining Issues on collab channel

Tristina1788 commented 2 months ago

🐞 Bug description

🔢 Steps to Reproduce

Create a basic game with some force and some channels
Login from admin page
Click on dropdown of button 'Add Channel'
Select 'Collab Edit' to create first collab channel
Create permission for this channel

Notice we have some issue below in wargame play

Text 'Chat' and 'Response' are hard to see. And When message still haven't had response yet, it shows as the white long button. It makes user don't know what it is

Expected : Text 'Chat' and 'Response' should be bold and white color as 'Feedback' text. And when message doesn't have response, we should not show that part.

With this permission, Message with status 'InProgress' (Edit), user role 'CanSubmitForReview'should has button 'Submit for review', 'Save'

Message with status 'InProgress' (Edit), user role 'CanApproved' should has button 'Save', 'Submit for review'

Message with status 'InProgress' (Edit), user role 'CanRelease' should has button 'Save', 'Submit for review', 'Release'

Message with status 'InProgress' (Edit), user role 'CanUnClaim' should has button 'Save', 'Submit for review', 'Release','Unclaim

I think we have 2 status 'Pending' and 'Review' but now I see it has 'Pending Review'

=> What is the correct one?

The UI is quite messing and it's hard to follow the action

https://github.com/serge-web/serge/assets/107697044/5014ae6d-c6e6-444b-a10a-a682ea9225ee

'Assign' button is not stable. I have to try click many time to make it work.

https://github.com/serge-web/serge/assets/107697044/140e718d-fc7c-412a-b1d4-a5ebcf5a2cfc

No action happens when approve for message which in status 'Pending Review'

https://github.com/serge-web/serge/assets/107697044/95e855ab-2e26-4316-bb73-315488237ba7

lilitkarapetyan commented 1 month ago

🐞 Bug description

We need to fix some remaining Issues on collab channel

🔢 Steps to Reproduce

1. Create a basic game with some force and some channels

2. Login from admin page

3. Click on dropdown of button 'Add Channel'

4. Select 'Collab Edit' to create first collab channel

5. Create permission for this channel

6. Notice we have some issue below in wargame play

* Text 'Chat' and 'Response' are hard to see. And When message still haven't had response yet, it shows as the white long button. It makes user don't know what it is

Expected : Text 'Chat' and 'Response' should be bold and white color as 'Feedback' text. And when message doesn't have response, we should not show that part.

* With this permission, Message with status 'InProgress' (Edit), user role 'CanSubmitForReview'should has button 'Submit for review', 'Save'

* Message with status 'InProgress' (Edit), user role 'CanApproved' should has button 'Save', 'Submit for review'

* Message with status 'InProgress' (Edit), user role 'CanRelease' should has button 'Save', 'Submit for review', 'Release'

* Message with status 'InProgress' (Edit), user role 'CanUnClaim' should has button 'Save', 'Submit for review', 'Release','Unclaim

Hi, I checked it. I thinks when the user clicks the Calm button and starts (In progress), they can do the actions mentioed.

lilitkarapetyan commented 1 month ago

🐞 Bug description

We need to fix some remaining Issues on collab channel

🔢 Steps to Reproduce

1. Create a basic game with some force and some channels

2. Login from admin page

3. Click on dropdown of button 'Add Channel'

4. Select 'Collab Edit' to create first collab channel

5. Create permission for this channel

6. Notice we have some issue below in wargame play

* Text 'Chat' and 'Response' are hard to see. And When message still haven't had response yet, it shows as the white long button. It makes user don't know what it is

Expected : Text 'Chat' and 'Response' should be bold and white color as 'Feedback' text. And when message doesn't have response, we should not show that part.

* With this permission, Message with status 'InProgress' (Edit), user role 'CanSubmitForReview'should has button 'Submit for review', 'Save'

* Message with status 'InProgress' (Edit), user role 'CanApproved' should has button 'Save', 'Submit for review'

* Message with status 'InProgress' (Edit), user role 'CanRelease' should has button 'Save', 'Submit for review', 'Release'

* Message with status 'InProgress' (Edit), user role 'CanUnClaim' should has button 'Save', 'Submit for review', 'Release','Unclaim

Hi @Tristina1788 , I checked it. I thinks when the user clicks the Calm button and starts (In progress), they can do the actions mentioed.

Tristina1788 commented 1 month ago

@lilitkarapetyan This is the permission for state 'InProgress' (Edit)

And user Blue - Co1 can have these permission but the new user role / Blue- Co2 (with same config permission) is not

IanMayo commented 1 month ago

Hello @Tristina1788 - isn't the CO 1 role being given extra operations because they currently "own" the document? If one user has claimed a message and are editing, we can't allow another user to do anything to it. Some users can un-claim a message, which then means others can apply operations onto it.

Tristina1788 commented 1 month ago

Hello @Tristina1788 - isn't the CO 1 role being given extra operations because they currently "own" the document? If one user has claimed a message and are editing, we can't allow another user to do anything to it. Some users can un-claim a message, which then means others can apply operations onto it.

Yeah, seem it works this way. I try to use another user with same permission, clam the message and it can shows the expected permissions. I'm checking more.

Tristina1788 commented 1 month ago

Hello @Tristina1788 - isn't the CO 1 role being given extra operations because they currently "own" the document? If one user has claimed a message and are editing, we can't allow another user to do anything to it. Some users can un-claim a message, which then means others can apply operations onto it.

@IanMayo But another status (example : Pending Review) user is not an owner , still have permissions list on chart. So only 'InProgress' need be an owner to have permissions?

IanMayo commented 1 month ago

Well, I "think" this is the logic. If a message has an owner, then only that owner can change it (regardless of the permissions of other roles). But, if it doesn't have an owner, players are given the relevant set of permissions.

IanMayo commented 1 month ago

Hello @Tristina1788 - to ensure you are testing the newest code, you should move to your testing/feedback to this PR please: #2976

lilitkarapetyan commented 1 month ago

'Assign' button is not stable. I have to try click many time to make it work.

After you select the button, you need to clicik it. - https://gyazo.com/9e67dac081df9540a798c6e0f0a2bc53

Tristina1788 commented 1 month ago

'Assign' button is not stable. I have to try click many time to make it work.

After you select the button, you need to clicik it. - https://gyazo.com/9e67dac081df9540a798c6e0f0a2bc53

@lilitkarapetyan With this way I can assign user well. But I think it's not normal way for user. They often think just select user and don't think about click again on that button to make the assignment can do action. @IanMayo How do you think?

Tristina1788 commented 1 month ago

@lilitkarapetyan The text is hard to see.

We have 2 scroll bars but seem the right one is not useful . (More details on this screencast : https://app.screencast.com/Ft4cPultQhcAP)

IanMayo commented 1 month ago

@lilitkarapetyan With this way I can assign user well. But I think it's not normal way for user. They often think just select user and don't think about click again on that button to make the assignment can do action. @IanMayo How do you think?

Good point @Tristina1788 . Would it be hard to implement it in @Tristina1788 's way, @lilitkarapetyan ?

Tristina1788 commented 1 month ago

I can't open content message after update channel with option 'Additional data' = true . I try to update it as original ('Additional data' = false) but I still can't open content message.

https://github.com/serge-web/serge/assets/107697044/372a8879-c5dc-4fa8-b3f2-95eeacbaf4c1

IanMayo commented 1 month ago

I can't open content message after update channel with option 'Additional data' = true . I try to update it as original ('Additional data' = false) but I still can't open content message.

When @lilitkarapetyan tries to reproduce this I expect she will learn that we need to check if the field is present before trying to render the message.

Tristina1788 commented 1 month ago

I can't open content message after update channel with option 'Additional data' = true . I try to update it as original ('Additional data' = false) but I still can't open content message.

cannot_open_message_after_change_and_revertAdditionaldata.mp4

We don't have 'location' in the message from UI. I don't know if it can get any where else. But At least, it should can be opened message after I reverted the config for 'Additional data' . Now I don't have anyway to open message and need to revert server/DB file.

lilitkarapetyan commented 1 month ago

@lilitkarapetyan With this way I can assign user well. But I think it's not normal way for user. They often think just select user and don't think about click again on that button to make the assignment can do action. @IanMayo How do you think?

Good point @Tristina1788 . Would it be hard to implement it in @Tristina1788 's way, @lilitkarapetyan ?

I don't think it will be difficult

IanMayo commented 1 month ago

@lilitkarapetyan With this way I can assign user well. But I think it's not normal way for user. They often think just select user and don't think about click again on that button to make the assignment can do action. @IanMayo How do you think?

Good point @Tristina1788 . Would it be hard to implement it in @Tristina1788 's way, @lilitkarapetyan ?

I don't think it will be difficult

Great - let's go for it, please.

Tristina1788 commented 1 month ago

@lilitkarapetyan The text is hard to see. => It's fixed and better. But with me, the text 'Threat' is not good. It's not the same style with another text. @IanMayo How do you think about it?

The redundant scroll bar is removed as expected

Now I can click assign user by select user as expected

https://github.com/serge-web/serge/assets/107697044/f1971c7f-36ed-4e1c-acda-43d932684188

IanMayo commented 1 month ago

Any remaining issues @Tristina1788 ?

Tristina1788 commented 1 month ago

I can't open content message after update channel with option 'Additional data' = true . I try to update it as original ('Additional data' = false) but I still can't open content message.

cannot_open_message_after_change_and_revertAdditionaldata.mp4

@IanMayo We still have this issue. Will we fix it on this ticket?

Get white screen when click on 'Sort' of Owner column

IanMayo commented 1 month ago

Yes please @Tristina1788 - I'd like @lilitkarapetyan to fix it in this issue. Hmm, or are you reporting two issues in that comment?

Tristina1788 commented 1 month ago

Yes please @Tristina1788 - I'd like @lilitkarapetyan to fix it in this issue. Hmm, or are you reporting two issues in that comment?

@IanMayo Yes, theye 're 2 issues:

I can't open content message after update channel with option 'Additional data' = true . I try to update it as original ('Additional data' = false) but I still can't open content message. => This issue also happens when I update config to 'Unallocated' option

https://github.com/serge-web/serge/assets/107697044/8d6bb1bd-9566-41ad-809c-a96d42dabb3a

Get white screen when click on 'Sort' of Owner column

And I also need your confirm on this. Do you feel this text 'Threat' is ok? With me, it's quite not good because it looks different style with another text on message.

Tristina1788 commented 1 month ago

@lilitkarapetyan @IanMayo Now the text 'Threat' is better on table but it's not good on form 'New message'

I can sort 'Owner' without issue, but the function sorting is not correct. It's not follow a->z desc/ascs ( Sorting on 'Updated' is also not good, it should be sort as date time instead of a->z) : https://app.screencast.com/qWTD8YoXqzEJ8

IanMayo commented 1 month ago

Yes @Tristina1788 - the Threat title is not clear. I'm sure @lilitkarapetyan can solve it via CSS.

Tristina1788 commented 1 month ago

@lilitkarapetyan Now the text 'Threat' is good on table and on 'New message'

Tristina1788 commented 1 month ago

@lilitkarapetyan @IanMayo Now I can send message after update channel with option 'Additional data' = true or update config to 'Unallocated' option as expected.

And I find one issue with new channel collab. It shows 'Chat' as default of template in Collab channel. But from game play, it doesn't show input text . I have to remove 'Chat' template and re-select it, then it can work as normal. => The default template should be fine to send message

https://github.com/serge-web/serge/assets/107697044/98b13747-1305-41e0-9a1a-8fe253b21051

And in 'Terminology' part, I can't select value of Request Changes / Approve/ Release. Is this ok for now? @IanMayo

https://github.com/serge-web/serge/assets/107697044/a2b32356-c658-40c3-96c6-2b15e461c872

Tristina1788 commented 1 week ago

@IanMayo @lilitkarapetyan

"With new channel collab. It shows 'Chat' as default of template in Collab channel. " => It's fixed by don't have default template on new collab channel.

''Terminology' part, I can't select value of Request Changes / Approve/ Release after removing' => The issue is not fixed.
I can sort 'Owner' without issue, but the function sorting is not correct. It's not follow a->z desc/ascs ( Sorting on 'Updated' is also not good, it should be sort as date time instead of a->z) => It's not fixed

Tristina1788 commented 4 days ago

@lilitkarapetyan @IanMayo Now I can sort column datetime ( ID, Updated) as dateTime as expected.

''Terminology' part, I can't select value of Request Changes / Approve/ Release after removing' => The issue is not fixed.

IanMayo commented 18 hours ago

@lilitkarapetyan @IanMayo Now I can sort column datetime ( ID, Updated) as dateTime as expected.

''Terminology' part, I can't select value of Request Changes / Approve/ Release after removing' => The issue is not fixed.

Here is how I did it @Tristina1788 : https://i.gyazo.com/2a20f9c6726a0acbed016c701a8d33a7.mp4

Tristina1788 commented 17 hours ago

@lilitkarapetyan @IanMayo Now I can sort column datetime ( ID, Updated) as dateTime as expected. ''Terminology' part, I can't select value of Request Changes / Approve/ Release after removing' => The issue is not fixed.

Here is how I did it @Tristina1788 : https://i.gyazo.com/2a20f9c6726a0acbed016c701a8d33a7.mp4

@IanMayo How user remember which template to input (I think they don't notice the name before delete) . And with that we can can input all name, that's not the exist template from system?

IanMayo commented 15 hours ago

For the terminology, these aren't template names, these are verbs used to record interactions.

Tristina1788 commented 2 hours ago

For the terminology, these aren't template names, these are verbs used to record interactions.

Yes, I understand how it works now. It's not an issue. So we can close ticket.

serge-web / serge