serge-web / serge

Serious Gaming, Evolved - web interface
https://sites.google.com/deepbluec.com/serge/
Apache License 2.0
14 stars 4 forks source link

Updated requirements for WA message #2961

Closed IanMayo closed 1 month ago

IanMayo commented 1 month ago

Fixes #2960

IanMayo commented 1 month ago

This branch is using the legacy JSON-Editor.

We have an issue in the layout for the legacy JSON-Editor, it's the two scroll-bars that are displayed (see below).

@lilitkarapetyan - could you help us out by fixing the layout so that they are not displayed? The fix will be a new commit in the branch for this PR, please.

image

Tristina1788 commented 1 month ago

@IanMayo, @lilitkarapetyan When I send new message without input, it will get the same content which the last message

Steps:

  1. Playgame with role Blue- Blue 3rd Party
  2. Send the first message with some input content
  3. Send the second new message without input infor message
  4. Notice the second message has same content with the first message

https://github.com/serge-web/serge/assets/107697044/ef39b3a9-311d-49d6-92eb-49304878c44a

IanMayo commented 1 month ago

@IanMayo, @lilitkarapetyan When I send new message without input, it will get the same content which the last message

Steps:

  1. Playgame with role Blue- Blue 3rd Party
  2. Send the first message with some input content
  3. Send the second new message without input infor message
  4. Notice the second message has same content with the first message

Hello @Tristina1788 - that's another issue related to the player experience for new message templates. I'd like this PR to focus on the admin pages. So could you create that as a new issue please?

Captured as #2963