Closed lilitkarapetyan closed 1 month ago
Thanks @lilitkarapetyan
This new control is suffering from data-loss, I think it's when the heartbeat pings: https://github.com/serge-web/serge/issues/2962
Could you make the contents persistent please?
@Tristina1788 - can you check that we don't lose messages after a few seconds?
Note: I've confirmed locally that we don't lose messages when admin updates the wargame, or when a new message is received in that channel.
@Tristina1788 - can you check that we don't lose messages after a few seconds?
Note: I've confirmed locally that we don't lose messages when admin updates the wargame, or when a new message is received in that channel.
@IanMayo Yes, It's fixed. Now the message is not reset any more
https://github.com/serge-web/serge/assets/107697044/15ae21a1-5151-4193-bd62-fb423f647b93
@IanMayo @lilitkarapetyan The copy/page the text on form is not good. It will get the format of the element instead of only the value. Do you think it's the issue or we can accept it?
https://github.com/serge-web/serge/assets/107697044/cc71b3b6-187c-47c4-beb7-f3ba9f3b040c
@IanMayo @lilitkarapetyan The copy/page the text on form is not good. It will get the format of the element instead of only the value. Do you think it's the issue or we can accept it?
copy-paste-format-not-good.mp4
Yes it's a strange behaviour @Tristina1788 - and well done for spotting it. But, I'm not worried about it. It is quite clear to users that the operation didn't work as expected.
Hello @lilitkarapetyan - for that copy/paste issue, can you remind me why we had the previous behaviour?
Hello @lilitkarapetyan - for that copy/paste issue, can you remind me why we had the previous behaviour?
I wrote a custom function (copyToClipboard) to easily copy schemas and uiSchemas for Storybook mock data.
@lilitkarapetyan @IanMayo I can copy value as expected now
https://github.com/serge-web/serge/assets/107697044/7d5df5db-77b9-4a11-8f65-1cfcb4b47926
@IanMayo , @Tristina1788 Note : I fixed the isues of #2972 in this PR.
@lilitkarapetyan @IanMayo Now the 'Cancel' and 'Send Message' is removed from admin and user play as expected.
A couple of conflicts to resolve here, please @lilitkarapetyan
Fixes #2967
π§° Issue
π Overview:
π Link to preview
π€ Reason:
π¨Work carried out:
π₯οΈ Screenshot
Confirmations
π Developer Notes: